Mistři v programování na #hovnokod

vlastně ani nevim, kde začít... co je nejhorší

 401                 String list[] = xmListOutput.split("\n");
 402                 if (list == null || list.length <= 0) {
 403                     return retVal;
 404                 }
 405                 for (String vm : list) {
 406                     if (vm == null) {
 407                         continue;
 408                     }
 409                     vm = vm.trim();
 410                     if (!vm.isEmpty()) {                        
 411                         String[] arr = vm.split(",");
 412                         if (arr == null || arr.length != 2){
 413                             logger.warn("VM:" + vm);
 414                             continue;
 415                         }
 416                         retVal.put(arr[0], arr[1]);
 417                         if (logger.isDebugEnabled()){
 418                             logger.debug("Discovered VM: "+arr[0]+","+arr[1]);
 419                         }
 420                     }
 421                 }

Anonymous,

        if (!povoleneRidiciParametry.contains(ridiciParametrRolaKlient)) {
            ridiciParametrRolaKlient = VYCHOZI_RIDICI_PARAMETR;
        }

Anonymous,

som zdedil kod

if (wft.currentState.name == "bla" && wft.currentState.name != "blabla")
     nieco
else
     nieco

Anonymous,

I takto lze posilat unikatni identifikator XML zpravy....

<ns:messageUniqueId>TODO</ns:messageUniqueId>

Anonymous,

Naprosto zbytecne plytvani pameti

        SimpleDateFormat dt1 = new SimpleDateFormat("yyyy");
        SimpleDateFormat dt2 = new SimpleDateFormat("MM");
        archivType.setObdobi(dt1.format(new Date()) + dt2.format(new Date()));

Anonymous,